feat(settings): Split and update design ConfirmTotpResetPassword#18853
Merged
vpomerleau merged 1 commit intomainfrom May 13, 2025
Merged
feat(settings): Split and update design ConfirmTotpResetPassword#18853vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
bcolsson
approved these changes
May 12, 2025
chenba
reviewed
May 12, 2025
| confirm-backup-code-reset-password-confirm-button = Confirm | ||
| confirm-backup-code-reset-password-subheader = Enter backup authentication code | ||
| confirm-backup-code-reset-password-instruction = Enter one of the one-time-use codes you saved when you set up two-step authentication. | ||
| # Lin out to support article: https://support.mozilla.org/kb/what-if-im-locked-out-two-step-authentication |
Contributor
There was a problem hiding this comment.
Suggested change
| # Lin out to support article: https://support.mozilla.org/kb/what-if-im-locked-out-two-step-authentication | |
| # Link out to support article: https://support.mozilla.org/kb/what-if-im-locked-out-two-step-authentication |
chenba
approved these changes
May 12, 2025
Because: * We are setting up this flow to expand and include recovery phone option * We want to simplify components and remove internal branches between 2FA TOTP and backup authentication codes * We want to assign individual routes to each page * We want to update to the new designs for these pages This commit: * Split ConfirmTotpResetPassword into to components (adding ConfirmBackupCodeResetPassword) * Update design of both pages * Add missing localization * Swap FormVerifyCode to FormVerifyTotp that disables input unless code of correct length is input * Add container tests * Fix act warning in CompleteResetPassword tests Closes #FXA-11511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11511
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Latest design:
https://www.figma.com/design/Xnjs0YApSnC0CV6Ns5gCt4/2SV_Security_key_flow-Email_phone_number_2023?node-id=9947-15331&t=SOZL48jY1eKafOMr-4