fix(settings): make ModalVerifySession's input validation work on the first attempt#18856
Merged
MagentaManifold merged 1 commit intomainfrom May 13, 2025
Merged
fix(settings): make ModalVerifySession's input validation work on the first attempt#18856MagentaManifold merged 1 commit intomainfrom
MagentaManifold merged 1 commit intomainfrom
Conversation
… first try Because: * “Verify” button becomes enabled while typing letters during the unverified session state This commit: * makes ModalVerifySession's input validation work on the first try Closes #FXA-2704
vpomerleau
approved these changes
May 12, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Nice work! Tested in storybook and working as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-2704
Checklist
Put an
xin the boxes that apply