fix(payments-next): Update layout/page metadata#18861
Merged
elizabeth-ilina merged 1 commit intomainfrom May 20, 2025
Merged
Conversation
elizabeth-ilina
force-pushed
the
FXA-11389
branch
8 times, most recently
from
23602fc to
c34a076
Compare
elizabeth-ilina
force-pushed
the
FXA-11389
branch
2 times, most recently
from
c041a9d to
2ee0ca4
Compare
elizabeth-ilina
force-pushed
the
FXA-11389
branch
from
2ee0ca4 to
6b560a1
Compare
david1alvarez
approved these changes
May 16, 2025
Contributor
david1alvarez
left a comment
david1alvarez
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for all the changes
julianpoy
reviewed
May 20, 2025
julianpoy
reviewed
May 20, 2025
Comment on lines
+41
to
+44
| 'Error', | ||
| 'There was an error processing your subscription. If this problem persists, please contact support.', | ||
| 'error', | ||
| 'checkout', |
Member
There was a problem hiding this comment.
Do these need to be localized, or are they localized elsewhere?
Contributor
There was a problem hiding this comment.
Oh yes, good catch. This totally skipped my mind, even though it is the first requirement in the ticket. Sorry about that.
Do we have a follow up ticket for this @elizabeth-ilina
julianpoy
reviewed
May 20, 2025
elizabeth-ilina
force-pushed
the
FXA-11389
branch
from
6b560a1 to
29e23cf
Compare
Because: * All page titles and descriptions are currently hard-coded, and metadata isn't localized. This commit: * Adds localization to layout/page metadata. * Adds product name from CMS to the metadata title. * Includes openGraph Closes #FXA-11389
elizabeth-ilina
force-pushed
the
FXA-11389
branch
from
29e23cf to
7b8889c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
All page titles and descriptions are currently hard-coded, and metadata isn't localized. This commit:
Adds localization to layout/page metadata.
Adds product name from CMS to the metadata title.
Includes openGraph
Closes #FXA-11389
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.