Skip to content

fix(email-first): fix flicker of email-first page#18863

Merged
nshirley merged 1 commit intomainfrom
FXA-11642
May 15, 2025
Merged

fix(email-first): fix flicker of email-first page#18863
nshirley merged 1 commit intomainfrom
FXA-11642

Conversation

@nshirley
Copy link
Copy Markdown
Contributor

@nshirley nshirley commented May 14, 2025 •
edited
Loading

Because

  • There is a potential for a momentary flash of the email-first page while already signed in

This pull request

  • Adds a loading state and spinner to hide the email-first page until ready

Issue that this pull request solves

Closes: FXA-11642

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

nshirley
nshirley commented May 14, 2025
View reviewed changes
Comment thread packages/fxa-settings/src/pages/Index/container.tsx Outdated
nshirley
nshirley commented May 14, 2025
View reviewed changes
Comment thread packages/fxa-settings/src/pages/Index/container.tsx
@nshirley nshirley force-pushed the FXA-11642 branch 3 times, most recently from 5c9192c to d5e3d71 Compare May 14, 2025 17:02
@nshirley nshirley marked this pull request as ready for review May 14, 2025 17:02
@nshirley nshirley requested a review from a team as a code owner May 14, 2025 17:02
@nshirley nshirley requested a review from vpomerleau May 14, 2025 17:55
vpomerleau
vpomerleau requested changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! I commented with some tweaks to when loading is set to false

Comment thread packages/fxa-settings/src/pages/Index/container.tsx
Comment thread packages/fxa-settings/src/pages/Index/container.tsx Outdated
Comment thread packages/fxa-settings/src/pages/Index/container.tsx Outdated
Comment thread packages/fxa-settings/src/pages/Index/container.tsx Outdated
@nshirley nshirley force-pushed the FXA-11642 branch 2 times, most recently from 3a742d6 to 0e2cc71 Compare May 15, 2025 15:20
@nshirley
fix(email-first): fix flicker of email-first page
aa366a8 
Because:
- There is a potential for a momentary flash of the email-first page
  while signed in

This Commit:
- Adds a loading state and spinner to hide the email-first page until
  ready

Closes: FXA-11642
@nshirley nshirley requested a review from vpomerleau May 15, 2025 15:27
vpomerleau
vpomerleau approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks sound! :shipit:

@nshirley nshirley merged commit 8d6c57a into main May 15, 2025
19 checks passed
@nshirley nshirley deleted the FXA-11642 branch May 15, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpomerleau vpomerleau vpomerleau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshirley @vpomerleau