Skip to content

feat(next): upgrade shows incorrect interval#18867

Merged
StaberindeZA merged 1 commit intomainfrom
fxa-11605-upgrade-plan-info
May 16, 2025
Merged

feat(next): upgrade shows incorrect interval#18867
StaberindeZA merged 1 commit intomainfrom
fxa-11605-upgrade-plan-info

Conversation

@StaberindeZA
Copy link
Copy Markdown
Contributor

@StaberindeZA StaberindeZA commented May 14, 2025

Because

  • The purchase details component for upgrades shows the incorrect interval and currency amount during an upgrade.

This pull request

  • Fetches the correct price amounts for the customers currency
  • Converts Stripe intervals to SubplatIntervals

Issue that this pull request solves

Closes: #FXA-11605 #FXA-11457

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@StaberindeZA StaberindeZA force-pushed the fxa-11605-upgrade-plan-info branch 2 times, most recently from d0d2cce to 5972989 Compare May 15, 2025 15:05
@StaberindeZA StaberindeZA marked this pull request as ready for review May 15, 2025 18:17
@StaberindeZA StaberindeZA requested a review from a team as a code owner May 15, 2025 18:17
xlisachan
xlisachan reviewed May 15, 2025
View reviewed changes
Comment thread libs/payments/cart/src/lib/cart.service.ts Outdated
listAmount: eligibility.fromPrice.unit_amount,
currency: priceForCurrency.currency,
interval,
listAmount: unitAmountForCurrency,
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could we update listAmount to unitAmount?

@StaberindeZA
feat(next): upgrade shows incorrect interval
ba5d694 
Because:

- The purchase details component for upgrades shows the incorrect
  interval and currency amount during an upgrade.

This commit:

- Fetches the correct price amounts for the customers currency
- Converts Stripe intervals to SubplatIntervals

Closes #FXA-11605 #FXA-11457
@StaberindeZA StaberindeZA force-pushed the fxa-11605-upgrade-plan-info branch from 5972989 to ba5d694 Compare May 16, 2025 15:01
xlisachan
xlisachan approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pulled down the branch and see that the Upgrade page shows the correct interval and currency. Thanks Reino!

@StaberindeZA StaberindeZA merged commit 21b6d03 into main May 16, 2025
19 checks passed
@StaberindeZA StaberindeZA deleted the fxa-11605-upgrade-plan-info branch May 16, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaberindeZA @xlisachan