Conversation
chenba
reviewed
May 19, 2025
| onContinueWithApple, | ||
| showSeparator = true, | ||
| viewName = 'unknown', | ||
| deeplink, |
Contributor
There was a problem hiding this comment.
I thought eslint auto fixes idents?
StaberindeZA
approved these changes
May 19, 2025
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
r+ with a question. Just had a question regarding the ref being used in the useCallback.
Tested it locally and works as expected.
Comment on lines
+187
to
+189
| if (stateRef.current) { | ||
| stateRef.current.value = getState(); | ||
| } |
Contributor
There was a problem hiding this comment.
Should stateRef also be added as a dependency of the useCallback?
Contributor
Author
There was a problem hiding this comment.
When I added this in, it didn't work as expected. I'm going to merge as is and do a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-11678
Checklist
Other information (Optional)
To test goto
http://localhost:8080and clickSign In (Google). You will need to have Google auth configured locally.