Skip to content

fix(paypal): do not return inactive billing agreemnt ids#18901

Merged
StaberindeZA merged 1 commit intomainfrom
fxa-11679-paypal-payment-error
May 21, 2025
Merged

fix(paypal): do not return inactive billing agreemnt ids#18901
StaberindeZA merged 1 commit intomainfrom
fxa-11679-paypal-payment-error

Conversation

@StaberindeZA
Copy link
Copy Markdown
Contributor

Because

  • PaypalBillingAgreementManager returns billing agreement even if its status is not active.

This pull request

  • Update method to only return active billing agreement ids.

Issue that this pull request solves

Closes: #FXA-11679

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

- PaypalBillingAgreementManager returns billing agreement even if its
  status is not active.

This commit:

- Update method to only return active billing agreement ids.

Closes #FXA-11679
@StaberindeZA StaberindeZA requested a review from a team as a code owner May 21, 2025 15:50
@StaberindeZA StaberindeZA merged commit 4439a6c into main May 21, 2025
19 checks passed
@StaberindeZA StaberindeZA deleted the fxa-11679-paypal-payment-error branch May 21, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants