Conversation
dschom
approved these changes
Jun 11, 2025
Contributor
dschom
left a comment
There was a problem hiding this comment.
Seems good to me. test-unit just needs a mkdir -p var/public in the command. I'm geussing what's happening is that the prebuild creates the folder, but since the folder is empty it doesn't get added to the cache. Maybe circle-ci's workspace, or maybe this is a side effect of the new nx cache changes ... /nosture) At any rate, I think wants that's cleared up, this seems great, so pre-emptive r+.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
flatpackageIssue that this pull request solves
Closes: FXA-11867
Other information
I added this resolution after running into issues a couple months ago while bulk-updating packages. We've done numerous upgrades and resolution removals since then, and I'm hoping it "just works". After removing the resolution, the package still resolves at
5.0.2(no change), suggesting this removal is safe.