Skip to content

task: audit yarn resolutions – flat#19013

Merged
toufali merged 1 commit intomainfrom
resolution-flat
Jun 13, 2025
Merged

task: audit yarn resolutions – flat#19013
toufali merged 1 commit intomainfrom
resolution-flat

Conversation

@toufali
Copy link
Copy Markdown
Member

@toufali toufali commented Jun 11, 2025

Because

  • Yarn resolutions should be used as last resort
  • pinning old packages prohibits security patches

This pull request

  • removes the resolution for flat package

Issue that this pull request solves

Closes: FXA-11867

Other information

I added this resolution after running into issues a couple months ago while bulk-updating packages. We've done numerous upgrades and resolution removals since then, and I'm hoping it "just works". After removing the resolution, the package still resolves at 5.0.2 (no change), suggesting this removal is safe.

@toufali toufali requested a review from a team as a code owner June 11, 2025 16:58
@toufali toufali marked this pull request as draft June 11, 2025 19:39
Copy link
Copy Markdown
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. test-unit just needs a mkdir -p var/public in the command. I'm geussing what's happening is that the prebuild creates the folder, but since the folder is empty it doesn't get added to the cache. Maybe circle-ci's workspace, or maybe this is a side effect of the new nx cache changes ... /nosture) At any rate, I think wants that's cleared up, this seems great, so pre-emptive r+.

@toufali toufali marked this pull request as ready for review June 12, 2025 22:03
@toufali
Copy link
Copy Markdown
Member Author

toufali commented Jun 12, 2025

Thanks @dschom – I fixed the broken tests via #19028 and rebased this PR.

@toufali toufali merged commit 104f988 into main Jun 13, 2025
19 checks passed
@toufali toufali deleted the resolution-flat branch June 13, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants