fix(email): fix invalid ftl syntax in verifyAccountChange#19357
Merged
MagentaManifold merged 1 commit intomainfrom Aug 26, 2025
Merged
fix(email): fix invalid ftl syntax in verifyAccountChange#19357MagentaManifold merged 1 commit intomainfrom
MagentaManifold merged 1 commit intomainfrom
Conversation
Contributor
|
There's already #19356 |
MagentaManifold
force-pushed
the
FXA-12221-fix
branch
from
5f6c410 to
17852ef
Compare
MagentaManifold
commented
Aug 26, 2025
|
|
||
| <mj-text css-class="text-body-no-margin"> | ||
| <span data-l10n-id="verifyAccountChange-expiry-notice"> | ||
| <span data-l10n-id="verifyAccountChange-expiry-notice" data-l10n-args="<%- JSON.stringify({ expirationTime }) %>"> |
Contributor
Author
There was a problem hiding this comment.
@flodolo Hi! I just discovered another error that breaks l10n, so we still need this fix. (Fluent in email templates is a lot trickier 😅)
Contributor
Author
There was a problem hiding this comment.
Oops it's still not working
Because: * there is a syntax error in verifyAccountChange's en.ftl file This commit: * fixes the syntax error
MagentaManifold
force-pushed
the
FXA-12221-fix
branch
from
17852ef to
a4441ae
Compare
MagentaManifold
commented
Aug 26, 2025
|
|
||
| <mj-text css-class="text-body-no-margin"> | ||
| <span data-l10n-id="verifyAccountChange-expiry-notice"> | ||
| <span data-l10n-id="verifyAccountChange-expiry-notice" data-l10n-args="<%= JSON.stringify({ expirationTime }) %>"> |
Contributor
Author
There was a problem hiding this comment.
Phew it's working this time
4 tasks
flodolo
approved these changes
Aug 26, 2025
LZoog
approved these changes
Aug 26, 2025
| <%- code %> | ||
|
|
||
| verifyAccountChange-expiry-notice = "It expires in <%- expirationTime == 1 ? '1 minute' : expirationTime + ' minutes' %>." | ||
| verifyAccountChange-expiry-notice = "It expires in <%- expirationTime === 1 ? '1 minute' : expirationTime + ' minutes' %>." |
Contributor
There was a problem hiding this comment.
Does this not need a new ID since it hasn't been pulled over to pontoon yet?
Contributor
There was a problem hiding this comment.
No. The file failed to parse initially, I fixed it on our side now and it's now exposed. This is just mirroring the fix I already made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.