Conversation
dschom
force-pushed
the
FXA-12220
branch
6 times, most recently
from
3f5372b to
2e41dec
Compare
dschom
force-pushed
the
FXA-12220
branch
3 times, most recently
from
c62d3bf to
8e01d54
Compare
| recoveryCodes?: string[]; | ||
| }; | ||
|
|
||
| export type MfaScope = 'test'; |
There was a problem hiding this comment.
The MfaScope type is just 'test' doesn't look right. I thought it's a string that represents of describes the action the user wants to take with the token?
There was a problem hiding this comment.
What you thought is correct. Currently the endpoint we use for the POC takes a 'test' scope. I think this 'test' value will go away once start actually applying this endpoints.
|
My http://localhost:3030/settings/mfa_guard/test/auth_client looks different than your screenshot. What steps do I need to perform first? |
Because: - We want to wrap certain pages with an MFA requirement This Commit: - Updates the cache to hold a JWT - Creates a guard component that invokes the MFA Modal if the JWT is missing - Creates an error boundary that clears invalid or expired JWTs
I just restarted the stack, and verified that it appears to be work. Also attached is video of expected interactions. I noticed a test failed after rebasing on main and pushing this commit. Perhaps you were affected by this. It should be working now though. If you like you can test again when reviewing this PR, which also has an example of how to do this gql. Screen.Recording.2025-09-02.at.5.25.31.PM.mov |
2 participants
Because
This pull request
Issue that this pull request solves
Closes: FXA-12220, FXA-12305, FXA-12304
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Test driver page:
Other information (Optional)
There will be a couple follow ups filed for error handling. This PR doesn't currently address the following things:
To test manually, create account / login so that you are on the
/settingspage. Then manually navigate to/settings/mfa_guard/test/auth_clientand test flow / error boundary.