cleanup(2fa): Remove feature flags and associated old 2FA flows#19433
Merged
vpomerleau merged 1 commit intomainfrom Sep 15, 2025
Merged
cleanup(2fa): Remove feature flags and associated old 2FA flows#19433vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
vpomerleau
force-pushed
the
FXA-12183
branch
4 times, most recently
from
fae1bbe to
f732415
Compare
bcolsson
approved these changes
Sep 11, 2025
dschom
reviewed
Sep 12, 2025
| ); | ||
| assert.notDeepEqual( | ||
| result, | ||
| result.recoveryCodes, |
Contributor
There was a problem hiding this comment.
Was this a bug in the original test? I'm always little leery of notEqual, cause it is easy to get a false positive.
dschom
reviewed
Sep 12, 2025
| return this.api.replaceRecoveryCodes(this.sessionToken, options); | ||
| }; | ||
|
|
||
| Client.prototype.updateRecoveryCodes = function (codes) { |
Contributor
There was a problem hiding this comment.
Just curious, how are update and set functionally different?
Contributor
Author
There was a problem hiding this comment.
set can be used on initial 2FA setup (to add recovery codes before marking 2FA as enabled), compared to update which requires 2fa to already be enabled.
dschom
reviewed
Sep 12, 2025
| default: false, | ||
| doc: 'Enables a redesign of the 2fa setup flow from settings with recovery phone option', | ||
| format: Boolean, | ||
| env: 'FEATURE_FLAGS_UPDATED_INLINE_RECOVERY_SETUP_FLOW', |
Contributor
There was a problem hiding this comment.
Just a reminder to clean up webinfra too.
Contributor
Author
There was a problem hiding this comment.
Yep, I've added a note in the deploy doc already. :)
dschom
approved these changes
Sep 12, 2025
Contributor
dschom
left a comment
dschom
left a comment
There was a problem hiding this comment.
Gave it a couple drive bys. Nice clean up!
Because: * The updated flows are fully rolled out in production * The totp/create endpoint is no longer responsible for creating recovery codes This commit: * Remove updated2faSetupFlow, updatedInlineTotpSetupFlow, updatedInlineRecoverySetupFlow flags * Remove code from endpoint that optionally generated and returned recovery codes * Remove skipRecoveryCodes option * Remove old components * Remove tests for old flows * Remove conditional logic around flows Closes #FXA-12813
vpomerleau
force-pushed
the
FXA-12183
branch
from
f732415 to
577c9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12813
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.