fix(settings): missing 3rd-party auth string

[toufali]

Because

• new string was overwritten by PR changes/rebase

This pull request

• reintroduces the string

[LZoog]

I might be missing something but where is the fall back text for this? If we want to go with it just being "or", I'd just call out this is the only place where we'd rely on Fluent to replace the text for us 🤔

[toufali]

@LZoog It defaults to "or" here:

fxa/packages/fxa-settings/src/components/ThirdPartyAuth/index.tsx

Line 58 in e86ea31

<FtlMsg id={separatorTextId || 'third-party-auth-options-or'}>

– is there a better place to hold the default, or would you like me to add context about the default in the l10n comment?

[LZoog]

It doesn't matter to translators, more of an us thing so if Fluent doesn't replace the text or the ID is missing or any other reason, the correct English string would display. It would be my preference that "or" is used as the default for the corresponding FTL ID, and "Sign in with" has its own <FtlMsg> wrapper. I think this would need some tweaking so they've got their own FtlMsg:

<FtlMsg id={separatorTextId || 'third-party-auth-options-or'}>
  <div className="mx-4 text-base text-grey-300 font-extralight">
    or
  </div>
</FtlMsg>

[LZoog]

This can be done in another PR if you want btw, I know this one's just to add the string back, I'll r+ to unblock Bryan in case he's trying to get these over to Pontoon.

[MagentaManifold]

The better way is to pass in the localized string directly instead of passing in the FTL id, so that you can pass in ftlMessageResolver.getMsg('custom-ftl-id', 'Customized string') and get the customized fallback.

[LZoog]

Yep, that works too and agreed is preferable in this case!

[toufali]

will merge this for translation and improve under separate PR 👍