Skip to content

polish(settings): Add callback so calling code knows when MfaGuard is dismissed.#19443

Merged
dschom merged 1 commit intomainfrom
add-on-dismis-callback
Sep 15, 2025
Merged

polish(settings): Add callback so calling code knows when MfaGuard is dismissed.#19443
dschom merged 1 commit intomainfrom
add-on-dismis-callback

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Sep 12, 2025

Because

  • This will be needed by FXA-12230, but is probably also generally useful.

This pull request

  • Adds an onDismiss callback option to the MfaGuard

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner September 12, 2025 00:09
@dschom dschom force-pushed the add-on-dismis-callback branch from bfeebad to 3c7be0f Compare September 12, 2025 00:21
@dschom dschom merged commit 393cb19 into main Sep 15, 2025
19 checks passed
@dschom dschom deleted the add-on-dismis-callback branch September 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants