Skip to content

fix(payments-next): Date encoded within <strong> tags on the Payments Screen for IAP subscriptions#19455

Merged
elizabeth-ilina merged 1 commit intomainfrom
PAY-3261-date-encoded-in-strong-tags
Sep 18, 2025
Merged

fix(payments-next): Date encoded within <strong> tags on the Payments Screen for IAP subscriptions#19455
elizabeth-ilina merged 1 commit intomainfrom
PAY-3261-date-encoded-in-strong-tags

Conversation

@elizabeth-ilina
Copy link
Copy Markdown
Contributor

@elizabeth-ilina elizabeth-ilina commented Sep 16, 2025 •
edited
Loading

Because

  • Date encoded within strong tags on the Payments Screen for IAP subscriptions.
  • l10n.getString() was returning the actual string, which included strong tags.

This pull request

  • Uses l10n.getFragmentWithSource() instead.

Issue that this pull request solves

Closes: #PAY-3261

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

image image

Other information (Optional)

Any other information that is important to this pull request.

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3261-date-encoded-in-strong-tags branch 5 times, most recently from c0b9cbb to 6f88056 Compare September 17, 2025 20:20
@elizabeth-ilina
fix(payments-next): Date encoded within <strong> tags on the Payments…
a6fd2e0 
… Screen for IAP subscriptions

Because:

*

This commit:

*

Closes #PAY-3261
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3261-date-encoded-in-strong-tags branch from 6f88056 to a6fd2e0 Compare September 17, 2025 20:20
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review September 17, 2025 20:20
@elizabeth-ilina elizabeth-ilina requested a review from a team as a code owner September 17, 2025 20:20
xlisachan
xlisachan approved these changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks Liz!

@elizabeth-ilina elizabeth-ilina merged commit 18f2a39 into main Sep 18, 2025
19 checks passed
@elizabeth-ilina elizabeth-ilina deleted the PAY-3261-date-encoded-in-strong-tags branch September 18, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elizabeth-ilina @xlisachan