task(settings) Wrap add recovery phone and replace recovery with MFA guard#19469
Merged
vpomerleau merged 1 commit intomainfrom Sep 23, 2025
Merged
task(settings) Wrap add recovery phone and replace recovery with MFA guard#19469vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
dschom
force-pushed
the
FXA-12225
branch
6 times, most recently
from
cf3a62a to
482c25b
Compare
vbudhram
approved these changes
Sep 18, 2025
| // Decorate session token with scope | ||
| sessionToken.scope = decoded.scope; | ||
|
|
||
| console.log('!!! ', sessionToken); |
| try { | ||
| await account.addRecoveryPhoneWithJwt(phoneData.phoneNumber); | ||
| } catch (e) { | ||
| if (e && e.code === 401 && e.errno === 110) { |
Contributor
There was a problem hiding this comment.
We should probably pull these into constants at some point.
Contributor
Author
There was a problem hiding this comment.
Good call. Which reminds, @nshirley add this nice little helper function in this PR. I'll update my checks accordingly. https://github.com/mozilla/fxa/pull/19468/files#r2356422594
vpomerleau
approved these changes
Sep 22, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Looks good, I'll go ahead and merge this to apply some of these changes to 2FA setup. I'll pull in the remaining non-blocking change requests to the 2FA setup PR
vpomerleau
force-pushed
the
FXA-12225
branch
from
29c5343 to
723c85c
Compare
vpomerleau
force-pushed
the
FXA-12225
branch
from
723c85c to
df8fcd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
PageRecoveryPhoneSetupwith an MfaGuardAuthClient.recoveryPhoneCreateWithJwtAccount.addRecoveryPhoneto useAuthClient.recoveryPhoneCreateWithJwt/mfa/recovery_phone/createIssue that this pull request solves
Closes: FXA-12225, FXA-12233
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.