fix(next): enable close on alert dialog#19475
Merged
StaberindeZA merged 1 commit intomainfrom Sep 18, 2025
Merged
Conversation
StaberindeZA
commented
Sep 18, 2025
Comment on lines
-36
to
-42
| const [container, setContainer] = useState<HTMLElement | null>(null); | ||
| const [openDialog, setOpenDialog] = useState(true); | ||
|
|
||
| useEffect(() => { | ||
| if (!containerRef) { | ||
| setContainer(document.getElementById('header')); | ||
| } | ||
| }, []); |
Contributor
Author
There was a problem hiding this comment.
note: Removing this in favor of having the container default to the location where the Alert is added.
If an alternate container is needed, then it can be passed to the AlertBar component as a prop.
StaberindeZA
commented
Sep 18, 2025
| switch (variant) { | ||
| case AlertBarVariant.ERROR: | ||
| alertTypeStyle = 'bg-red-600 text-white'; | ||
| alertTypeStyle = 'bg-red-100 error'; |
Contributor
Author
There was a problem hiding this comment.
note: Matching the styles used by FxA. This was a suggestion made by UX/Product in PAY-3239
| </Dialog.Content> | ||
| </Dialog.Portal> | ||
| </Dialog.Root> | ||
| </Dialog.Root > |
Contributor
There was a problem hiding this comment.
nit: extra space here
elizabeth-ilina
approved these changes
Sep 18, 2025
julianpoy
approved these changes
Sep 18, 2025
bcolsson
approved these changes
Sep 18, 2025
Because: - Alert dialog was prevent users from using the breadcrumbs and the header menus. This commit: - Allow usage of header menus while alert is active - Always show dialog close button - Open PayPal management page in new window Closes #PAY-3270 PAY-3273 PAY-3274
StaberindeZA
force-pushed
the
pay-3270-paypal-banner
branch
from
347979f to
38377ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3270 PAY-3273 PAY-3274
Checklist
Put an
xin the boxes that applyScreenshots (Optional)