Skip to content

fix(settings): meet WCAG AA standard for 3rd-party auth divider text#19485

Merged
toufali merged 1 commit intomainfrom
fix-text-color-aa-standard
Sep 19, 2025
Merged

fix(settings): meet WCAG AA standard for 3rd-party auth divider text#19485
toufali merged 1 commit intomainfrom
fix-text-color-aa-standard

Conversation

@toufali
Copy link
Copy Markdown
Member

@toufali toufali commented Sep 19, 2025

Because

  • 3rd party auth text ("Or", "Sign in with") doesn't meet WCAG AA standard

This pull request

  • darkens the text color to #5E5E72
  • (I also added a storybook state specific for "Sign in with" case, which was missing)

Issue that this pull request solves

Closes: FXA-12419

Screenshots

Before:
Screenshot 2025-09-19 at 12 17 24 PM

After (it's subtle 😉):
Screenshot 2025-09-19 at 12 17 50 PM

@toufali toufali requested a review from a team as a code owner September 19, 2025 19:19
@toufali toufali force-pushed the fix-text-color-aa-standard branch 2 times, most recently from b88684c to 6cf5e04 Compare September 19, 2025 19:31
@toufali toufali force-pushed the fix-text-color-aa-standard branch from 6cf5e04 to c8e6cba Compare September 19, 2025 19:33
Copy link
Copy Markdown
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! :shipit:

@toufali toufali merged commit 74a55a7 into main Sep 19, 2025
19 checks passed
@toufali toufali deleted the fix-text-color-aa-standard branch September 19, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants