Conversation
dschom
reviewed
Sep 19, 2025
| accountResetToken.verificationMethod | ||
| ); | ||
| } else if (recoveryKeyId) { | ||
| await this.db.verifyTokensWithMethod(sessionToken.id, 'totp-2fa'); |
Contributor
There was a problem hiding this comment.
I'd put a comment here about what this is doing. Without understanding the context around this change, it might seem like a mistake at first glance.
Because: * Account recovery key is considered equivalent to 2FA, and the issued token should match 2FA AAL This commit: * When using an account recovery key, verify token with totp-2fa method * Add a test to verify that this change allows account deletion Closes #FXA-12425
vpomerleau
force-pushed
the
FXA-12425
branch
from
0e103c9 to
393eba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12425
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.