Conversation
vpomerleau
reviewed
Dec 16, 2025
| signin-token-code-resend-code-link = Email new code. | ||
| # Countdown message shown when user must wait before resending code | ||
| # { $seconds } represents the number of seconds remaining | ||
| signin-token-code-resend-code-countdown = Email new code in { $seconds }s |
Contributor
There was a problem hiding this comment.
Suggested change
| signin-token-code-resend-code-countdown = Email new code in { $seconds }s | |
| signin-token-code-resend-code-countdown = | |
| { $seconds -> | |
| [one] Email new code in { $seconds } second | |
| *[other] Email new code in { $seconds } seconds | |
| } |
vpomerleau
reviewed
Dec 16, 2025
| setResendCodeLoading(true); | ||
| try { | ||
| await session.sendVerificationCode(); | ||
| // Start 30 second countdown |
Contributor
There was a problem hiding this comment.
Should the countdown start after setResendCodeLoading(false); ?
bcolsson
requested changes
Dec 16, 2025
bcolsson
approved these changes
Dec 18, 2025
vpomerleau
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12796
Checklist
Screenshots (Optional)
Other information (Optional)
I tried to make this a reuseable component but that was a much bigger refactor.