Conversation
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
Just a couple of small comments.
|
|
||
| const cancelInterstitialOffer = offers.at(0); | ||
| if (!cancelInterstitialOffer) { | ||
| return undefined as unknown as CancelInterstitialOfferTransformed; |
Contributor
There was a problem hiding this comment.
issue: undefined should not be cast to CancelInterstitialOfferTransformed
| isEligibleforChurnStaySubscribed: | ||
| churnStaySubscribedEligibility.isEligible, | ||
| }; | ||
| return await this.subscriptionManagementService.getStaySubscribedFlowContent( |
Contributor
There was a problem hiding this comment.
nitpick: await isn't necessary here.
Navigate to appropriate pages from the Subscription Management page, per subscription:
Stay subscribed flow
If the customer is eligible for the churn coupon, the “Stay subscribed” button will navigate to /[locale]/subscriptions/[subscription_id]/loyalty-discount/stay-subscribed
If no churn coupon is available, the “Stay subscribed” button will navigate to /[locale]/subscriptions/[subscription_id]/stay-subscribed
Cancel subscription flow
If customer is eligible for churn coupon, the “Cancel subscription” will navigate to /[locale/subscriptions/[subscription_id]/loyalty-discount/cancel
If no churn coupon is available, but there is a cancel interstitial offer, the “Cancel subscription” button will navigate to /[locale]/subscriptions/[subscription_id]/offer
If no churn coupon or cancel interstitial offer is available, the “Cancel subscription” button will navigate to /[locale]/subscriptions/[subscription_id]/cancel
Closes: PAY-3455
StaberindeZA
approved these changes
Jan 14, 2026
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
lgtm. Thank you for the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Navigate to appropriate pages from the Subscription Management page, per subscription:
Stay subscribed flow
Cancel subscription flow
Issue that this pull request solves
Closes: PAY-3455
Checklist
Put an
xin the boxes that apply