polish(accounts-email): A little polishing before building#19900
Merged
Conversation
nshirley
approved these changes
Jan 16, 2026
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Looks good to me - I think the failing tests will get fixed with a rebase
| content?: string | ||
| ): void { | ||
| // Don't include utm parameters if metrics are disabled. This flag | ||
| // comes from the users's account state and must be supplied. |
Contributor
There was a problem hiding this comment.
Really good to know! Thanks for catching this
|
|
||
| for (const [key, value] of Object.entries(opts)) { | ||
| link.searchParams.set(key, value); | ||
| if (value !== undefined) { |
| const { privacyUrl, supportUrl } = this.linkBuilder.buildCommonLinks(name); | ||
| // Build links for template | ||
| const initiatePasswordResetLink = | ||
| this.linkBuilder.buildInitiatePasswordResetLink( |
Contributor
There was a problem hiding this comment.
I like this, much cleaner to move that handling of additional params into the link builder 👍
dschom
force-pushed
the
fxa-mailer-polish
branch
4 times, most recently
from
77a412f to
9dcb037
Compare
- Pass in metrics enabled - Handle undefined params in `buildLInkWithQueryParam` - Small polish on compound types in fxa-mailer - Normalize on strings as format for links, not url objects - Better encapsulation for link builder.
dschom
force-pushed
the
fxa-mailer-polish
branch
from
9dcb037 to
2ec06f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
buildLInkWithQueryParamIssue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
This is pre-work for the using email lib in fxa-auth-server ticket.