feat(payments-next): Add Churn Intervention feature flag#19905
feat(payments-next): Add Churn Intervention feature flag#19905elizabeth-ilina merged 1 commit intomainfrom
Conversation
elizabeth-ilina
force-pushed
the
PAY-3469-add-churn-feature-flag
branch
2 times, most recently
from
e14c2cc to
9cfa36c
Compare
elizabeth-ilina
force-pushed
the
PAY-3469-add-churn-feature-flag
branch
from
9cfa36c to
96dbad4
Compare
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
r+wc
Just a few questions and a nitpick, but looks good otherwise.
Just a note, this will also require an update to the env vars in webservice-infra before this change lands in Stage and ultimately Prod
| public readonly collectionName!: string; | ||
|
|
||
| @IsBoolean() | ||
| public readonly enabled: boolean = true; |
There was a problem hiding this comment.
nitpick: Even though the default is already set here, could it also please be added to apps/payments/next/.env?
Currently that file serves as an easy single source to see what the default values are for the service.
There was a problem hiding this comment.
question: should this rather be disabled by default?
| if (!config.churnInterventionConfig.enabled) { | ||
| redirect(`/${locale}/subscriptions/${subscriptionId}/stay-subscribed`); | ||
| } |
There was a problem hiding this comment.
question: should logic like this be added to other churn related pages?
For example, I see that .../loyalty-discount/stay-subscribed/error/page.tsx also makes a call to action determineStaySubscribedEligibilityAction
Because: * We want to be able to enable/disable the churn intervention features using a flag. This commit: * Adds a churn intervention flag. Closes #PAY-3469
elizabeth-ilina
force-pushed
the
PAY-3469-add-churn-feature-flag
branch
from
96dbad4 to
e62ac23
Compare
|
Webservices-infra change: https://github.com/mozilla/webservices-infra/pull/9229 |
2 participants
Because
This pull request
Issue that this pull request solves
Closes: (issue number) #PAY-3469
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
churn-intervention-flag.mov
Other information (Optional)
Any other information that is important to this pull request.