Conversation
| 'churn-error-page-message-discount-already-applied', | ||
| { productName }, | ||
| `This discount was applied to a ${productName} subscription for your account. If you still need help, please contact our Support team.` | ||
| `This discount was applied to a ${productName} subscription for your account. If you still need help, contact our Support team.` |
There was a problem hiding this comment.
Updated as string in en.ftl is as follows:
churn-error-page-message-discount-already-applied = This discount was applied to a { $productName } subscription for your account. If you still need help, contact our Support team.
| enum ChurnCancelErrorReason { | ||
| AlreadyCanceling = 'already_canceling_at_period_end', | ||
| SubscriptionNotActive = 'subscription_not_active', | ||
| SubscriptionStillActive = 'subscription_still_active', | ||
| OfferExpired = 'no_churn_intervention_found', | ||
| GeneralError = 'general_error', | ||
| RedemptionLimitExceeded = 'redemption_limit_exceeded', | ||
| } |
There was a problem hiding this comment.
It looks like this is never really used as an enum, just converted to an array of strings (and casted) below. I'd probably just switch this to an array of strings as const.
There was a problem hiding this comment.
I don't think we need this anymore actually. If it's not an error reason that is considered "allowed", we will just navigate to the error page.
| return { | ||
| ...result, | ||
| cancelContent, | ||
| }; |
There was a problem hiding this comment.
[non-blocking] Imo we shouldn't combine return types like this. Instead return each separately.
return {
cancelChurnContentEligibility,
cancelFlowContent
}
xlisachan
force-pushed
the
PAY-3434
branch
8 times, most recently
from
178c20f to
0bb82c8
Compare
This pull requests Adds the following churn pages and en.ftl: Error Not Found Cancel/component Updates ChurnInterventionService redeemCoupon to include churnType determineCancelChurnContentEligibility to include additional reasons (subscription_not_active, already_canceling_at_period_end, adds cmsOfferingContent when needed Updates SubscriptionManagementService to return subscription invoice information Closes PAY-3434
3 participants
This pull request
Issue that this pull request solves
Closes: PAY-3434
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Reason: Eligible
Mobile
Tablet
Successfully redeemed
Mobile
Tablet
Reason: Already canceling
Mobile
Tablet
Reason: Discount already applied/Redemption limit exceeded
Mobile
Tablet
Reason: Subscription not active
Mobile
Tablet
Reason: No churn found
Mobile
Tablet
