fix(payments): replace assertion errors#19921
Merged
StaberindeZA merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
Because: - Ensure that assertion errors throw a unique error providing additional information related to the error. This commit: - Where necessary update assertion errors to throw a unique error. - Add tests for all assertion errors. Closes #PAY-3392
julianpoy
approved these changes
Jan 22, 2026
StaberindeZA
commented
Jan 22, 2026
Contributor
Author
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
note: I opted to keep asserts in cart.manager as is, since the cart.manager methods wrap each error with a CartManager error already.
Comment on lines
+2108
to
+2110
| await expect(cartService.getCart(mockCart.id)).rejects.toThrow( | ||
| /GetCartFromPriceMissingError/ | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
note: There's a known issue with assert and jest when adding a custom error message to your assert, jest still throws it as an AssertionError. Because of that, the way these tests check that the correct Error is thrown, is by checking if the Error name is included in the error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: PAY-3392
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.