Conversation
nshirley
reviewed
Jan 23, 2026
nshirley
reviewed
Jan 23, 2026
nshirley
reviewed
Jan 26, 2026
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Just doing a preliminary drive-by, I'll look again when it's settled
dschom
force-pushed
the
FXA-12884
branch
3 times, most recently
from
5c090db to
b34b796
Compare
nshirley
reviewed
Jan 27, 2026
nshirley
approved these changes
Jan 27, 2026
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Last come through looks good! 👍
I saw there was one last test failure but it looked unrelated to your changes. For fun I re-ran it to see if it passes. Otherwise, LGTM!!
dschom
force-pushed
the
FXA-12884
branch
2 times, most recently
from
1774a32 to
cce5277
Compare
dschom
changed the title
nshirley
pushed a commit
that referenced
this pull request
Jan 27, 2026
task(auth): Use new email library for sending emails in auth-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
auth-serverover to using the newfxa-mailer.Issue that this pull request solves
Closes: FXA-12884
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.