Conversation
Because: * Not having an explicit width on the split layout content is causing content sizing variations depending on how long the headline is This commit: * Adds an explicit width at desktop and above and moves padding/margin inward to better match the existing .card component fixes FXA-12794
LZoog
changed the title
vpomerleau
approved these changes
Jan 26, 2026
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
This change looks good to me, the width is now consistent across pages. I wasn't able to reproduce the issue you mentioned about top content being cutoff in some window configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
fixes FXA-12794
The first point of the issue was already addressed in another ticket.
For the second point, the split layout content appears to shift in width from email-first to signin. This happens because the email-first headline is much longer than the signin page headline, so the button and entire content grows. This fix still allows tablet content to shink in size which keeps the split layout 50/50 but keeps the width consistent at desktop and above, and also uses the same inner padding as
.cardso the content widths match.