Skip to content

Update subscription reminder emails on discount change#19961

Merged
elizabeth-ilina merged 3 commits intomainfrom
PAY-3485-update-subscription-reminder-emails-on-discount-change
Feb 4, 2026
Merged

Update subscription reminder emails on discount change#19961
elizabeth-ilina merged 3 commits intomainfrom
PAY-3485-update-subscription-reminder-emails-on-discount-change

Conversation

@elizabeth-ilina
Copy link
Copy Markdown
Contributor

@elizabeth-ilina elizabeth-ilina commented Jan 28, 2026

Because

  • Currently, the SubscriptionRenewalReminder emails don't handle cases when a customer’s discount is being replaced by a different discount. (PAY-3485)
  • Also, discount doesn't seem to appear on subscriptions, but invoice, so checking whether there is a discount on the subscription isn't working as expected. (PAY-3508)

This pull request

  • Updates subscription reminder emails to handle these situations. (PAY-3485)
  • Instead of checking if there is a discount on the subscription and a discount on the upcoming invoice, check whether there a discount on the latest invoice and a discount on the upcoming one (PAY-3508)

Issue that this pull request solves

Closes

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

image image

Other information (Optional)

Any other information that is important to this pull request.

…change.

Because:

* Currently, the SubscriptionRenewalReminder emails don't handle cases when a customer’s discount is being replaced by a different discount.

This commit:

* Updates subscription reminder emails to handle these situations.

Closes #[PAY-3485](https://mozilla-hub.atlassian.net/browse/PAY-3485)
Because:

*

This commit:

*

Closes #
@elizabeth-ilina elizabeth-ilina changed the title Pay 3485 update subscription reminder emails on discount change Update subscription reminder emails on discount change Jan 28, 2026
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3485-update-subscription-reminder-emails-on-discount-change branch 2 times, most recently from 820727a to 7386357 Compare January 28, 2026 19:44
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review January 29, 2026 13:11
@elizabeth-ilina elizabeth-ilina requested review from a team as code owners January 29, 2026 13:12
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3485-update-subscription-reminder-emails-on-discount-change branch from 7386357 to b566ede Compare January 29, 2026 21:34
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks Liz!

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3485-update-subscription-reminder-emails-on-discount-change branch 4 times, most recently from 90d4e70 to 7f6472e Compare January 30, 2026 16:24
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3485-update-subscription-reminder-emails-on-discount-change branch 5 times, most recently from 96fd24e to a3c5353 Compare February 4, 2026 14:50
…change

Because:

* SubscriptionRenewalReminder doesn't handle the case where a customer’s discount is being replaced by a different discount.

This commit:

* Handles that case

Closes #[PAY-3485](https://mozilla-hub.atlassian.net/browse/PAY-3485)
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3485-update-subscription-reminder-emails-on-discount-change branch from a3c5353 to 99c12c0 Compare February 4, 2026 15:01
Copy link
Copy Markdown
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the changes and discussion!

@elizabeth-ilina elizabeth-ilina merged commit 056213d into main Feb 4, 2026
21 checks passed
@elizabeth-ilina elizabeth-ilina deleted the PAY-3485-update-subscription-reminder-emails-on-discount-change branch February 4, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants