polish(auth): Only fail hard on email send for emails with codes#19968
Merged
polish(auth): Only fail hard on email send for emails with codes#19968
Conversation
nshirley
approved these changes
Jan 29, 2026
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Smart, I'll have some to update on my pr, but looks like it's just an optional param 👍
nshirley
reviewed
Jan 29, 2026
| headers: Record<string, string>, | ||
| rendered: RenderedTemplate | ||
| rendered: RenderedTemplate, | ||
| throwErrorOnSendFailure = true |
Contributor
There was a problem hiding this comment.
Just noticed, should this default to false?
dschom
force-pushed
the
dont-fail-on-email-send-error
branch
from
ce76f16 to
04f6257
Compare
dschom
force-pushed
the
dont-fail-on-email-send-error
branch
from
04f6257 to
ba7344f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
auth-serverto suppress errors for not critical emailsIssue that this pull request solves
Closes: FXA-13030
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.