feat(cms): Temporarily don't load splitLayout for non-EN locales#19976
Merged
feat(cms): Temporarily don't load splitLayout for non-EN locales#19976
Conversation
Because: * We want to do a temporary test of an image that has some text in it that can't be localized (noting, this is not great a11y) This commit: * Loads the normal layout but loads other cms content if the locale is not english closes FXA-12988
vpomerleau
approved these changes
Jan 30, 2026
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
This works as described, but just noting that we'll need revert and potentially dot release to turn this off since the condition is hard coded. This will also impact all RPs that have splitLayout turned on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-12988
fxa-12988.mov