fix(sentry): Register SentryGlobalFilter via dependency injection#20017
Merged
vpomerleau merged 1 commit intomainfrom Feb 9, 2026
Merged
fix(sentry): Register SentryGlobalFilter via dependency injection#20017vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
Because: * SentryGlobalFilter was instantiated without arguments, causing applicationRef to be undefined * When exceptions occurred, filter crashed on applicationRef.isHeadersSent() * Crashed filter left requests hanging without response, preventing Pub/Sub message acknowledgement * Unacked messages caused infinite redelivery loop (RP event distribution delays spiked to 2.31 days) This commit: * Passes httpAdapter from HttpAdapterHost to SentryGlobalFilter constructor in fxa-graphql-api, fxa-event-broker, and fxa-admin-server * Ensures filter can handle exceptions without crashing * Allows proper HTTP responses to Pub/Sub push endpoints so messages are acknowledged Closes #FXA-13031
dschom
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13031
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.