task(libs): Add passkeys data model and db migration by vpomerleau · Pull Request #20019 · mozilla/fxa

vpomerleau · 2026-02-09T19:56:41Z

Because

We are adding WebAuthn/FIDO2 passkey support

This pull request

Adds database migration creating passkeys table with composite primary key and proper indexing
Generates Kysely types (Passkey, NewPasskey, PasskeyUpdate) with type guards for validation
Implements 8 pure repository functions for CRUD operations following FxA patterns
Creates PasskeyFactory for generating test data and updates integration test infrastructure
Provides comprehensive field documentation in PASSKEY_FIELDS.md covering WebAuthn spec and usage

Issue that this pull request solves

Closes: FXA-12901

Checklist

Put an x in the boxes that apply

My commit is GPG signed.
If applicable, I have modified or added tests which pass locally.
I have added necessary documentation (if appropriate).
I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

vpomerleau · 2026-02-10T19:55:57Z

~~Tests are currently failing because of the db migration version - I've bumped up the patch number to accommodate #20020 that is approved and likely to land first.~~

This should now be resolved.

libs/accounts/passkey/PASSKEY_FIELDS.md

libs/shared/db/mysql/account/src/test/passkeys.sql

dschom · 2026-02-11T17:34:09Z

libs/accounts/passkey/PASSKEY_FIELDS.md

+
+### name
+
+- **Type**: string | null


Should this be nullable? Seems like we'd want to be consistent and require a name?

Good call, we do want this to be defined even if it's just with a default value like "Passkey"

Seems reasonable to me. I don't have a good feeling for what names would typically look like, but that seems fine.

libs/accounts/passkey/PASSKEY_FIELDS.md

dschom · 2026-02-11T17:39:27Z

libs/accounts/passkey/PASSKEY_FIELDS.md

+  - Software authenticators (browser built-in passkey managers)
+  - Privacy-focused hardware keys
+  - Platform authenticators (depending on policy)
+- **Normalization**: The PasskeyService normalizes all-zeros AAGUID to `NULL` before storage


Just curious we we need to do and maintain this null conversion on 00000000-0000-0000-0000-000000000000?

Not strictly necessary, I can directly store the all-zero value instead.

I'm good with either approach, but if there's not a good argument for storing a null value, I'd lean towards the stance that the fewer nullables we have the better.

dschom

Looks great. R+WC. The only thing I'd question is if cascade on delete is really a good idea... It's definitely convenient, but want to make sure we know it can also cause problems in some scenarios.

vbudhram · 2026-02-11T18:41:40Z

libs/accounts/passkey/src/lib/passkey.repository.ts

+    .where('credentialId', '=', credentialId)
+    .execute();
+
+  return result.length;


Does this always return 1? Thought there was a numUpdatedRows property

vbudhram · 2026-02-11T18:45:28Z

libs/accounts/passkey/src/lib/passkey.repository.ts

+ * @param uid - User ID (16-byte Buffer)
+ * @returns Array of passkeys for the user (unordered)
+ */
+export async function findPasskeysByUid(


Maybe overkill, but I suppose you could write some integration tests to verify the sql.

I've added a few simple tests!

Because: * We are adding WebAuthn/FIDO2 passkey support This commit: * Adds database migration creating passkeys table with composite primary key and proper indexing * Generates Kysely types (Passkey, NewPasskey, PasskeyUpdate) with type guards for validation * Implements 8 pure repository functions for CRUD operations following FxA patterns * Creates PasskeyFactory for generating test data and updates integration test infrastructure * Provides comprehensive field documentation in PASSKEY_FIELDS.md covering WebAuthn spec and usage Closes #FXA-12901

vpomerleau · 2026-02-11T20:29:32Z

Thanks @dschom and @vbudhram for comments! I've made some changes in a separate commit for easier review. Promise I'll squash/rebase before merging.

vbudhram · 2026-02-11T21:03:24Z

libs/accounts/passkey/src/lib/passkey.repository.in.spec.ts

+import { AccountManager } from '@fxa/shared/account/account';
+import * as PasskeyRepository from './passkey.repository';
+
+describe('PasskeyRepository (Integration)', () => {


dschom · 2026-02-12T01:05:48Z

packages/db-migrations/databases/fxa/patches/patch-184-185.sql

+  DELETE FROM securityEvents WHERE uid = uidArg;
+  DELETE FROM sentEmails WHERE uid = uidArg;
+  DELETE FROM linkedAccounts WHERE uid = uidArg;
+  DELETE FROM passkeys WHERE uid = uidArg;


dschom

LGTM!

vpomerleau force-pushed the FXA-12901 branch 2 times, most recently from fe27ff0 to 5907c00 Compare February 10, 2026 17:11

vpomerleau changed the title ~~wip~~ task(libs): Add passkeys data model and db migration Feb 10, 2026

vpomerleau marked this pull request as ready for review February 10, 2026 17:15

vpomerleau requested a review from a team as a code owner February 10, 2026 17:15

vpomerleau force-pushed the FXA-12901 branch from 5907c00 to 4f71766 Compare February 10, 2026 18:57

vpomerleau force-pushed the FXA-12901 branch 3 times, most recently from c003c2b to fdcb65f Compare February 10, 2026 23:04

dschom self-requested a review February 11, 2026 17:22

dschom reviewed Feb 11, 2026

View reviewed changes

libs/accounts/passkey/PASSKEY_FIELDS.md Outdated Show resolved Hide resolved

dschom reviewed Feb 11, 2026

View reviewed changes

libs/shared/db/mysql/account/src/test/passkeys.sql Show resolved Hide resolved

dschom reviewed Feb 11, 2026

View reviewed changes

libs/accounts/passkey/PASSKEY_FIELDS.md Outdated Show resolved Hide resolved

dschom reviewed Feb 11, 2026

View reviewed changes

dschom approved these changes Feb 11, 2026

View reviewed changes

vbudhram approved these changes Feb 11, 2026

View reviewed changes

vpomerleau force-pushed the FXA-12901 branch from fdcb65f to 8097077 Compare February 11, 2026 20:25

vpomerleau added 2 commits February 11, 2026 12:27

address PR review comments

512c441

vpomerleau force-pushed the FXA-12901 branch from 8097077 to 512c441 Compare February 11, 2026 20:28

vpomerleau requested review from dschom and vbudhram February 11, 2026 20:29

vbudhram reviewed Feb 11, 2026

View reviewed changes

vbudhram approved these changes Feb 11, 2026

View reviewed changes

dschom reviewed Feb 12, 2026

View reviewed changes

dschom approved these changes Feb 12, 2026

View reviewed changes

vpomerleau merged commit 30e2ded into main Feb 12, 2026
22 checks passed

vpomerleau deleted the FXA-12901 branch February 12, 2026 01:15

Conversation

vpomerleau commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Because

This pull request

Issue that this pull request solves

Checklist

Screenshots (Optional)

Other information (Optional)

Uh oh!

vpomerleau commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dschom Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dschom left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vpomerleau commented Feb 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dschom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vpomerleau commented Feb 9, 2026 •

edited

Loading

vpomerleau commented Feb 10, 2026 •

edited

Loading

dschom Feb 12, 2026 •

edited

Loading