Skip to content

Conversation

@sreecharan-desu
Copy link
Contributor

Because

The ConnectedServices tests started failing after recent changes, as they were still using the old groupedByName field.

This pull request

  • Removes the outdated groupedByName usage
  • Updates the tests to match the current return type
  • Fixes the TypeScript build errors

Issue that this pull request solves

Closes: #17370

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.

@sreecharan-desu
Copy link
Contributor Author

Note: This supersedes the earlier PR (#19931), which I accidentally closed while resolving the signing and build issues.

@MagentaManifold
Copy link
Contributor

I'm sorry, but this PR doesn't contain your earlier changes to the files, only updated tests. The updated test is also nonsensical.

@sreecharan-desu sreecharan-desu force-pushed the fix-connected-services-test branch from 82435eb to 5b02a8b Compare February 12, 2026 04:35
@sreecharan-desu
Copy link
Contributor Author

Thanks for catching that! I've restored the missing implementation file from the previous PR which I accidentally lost during the re-creation. The tests should make sense now as they align with the updated grouping logic.

@sreecharan-desu
Copy link
Contributor Author

ConnectedServices tests are passing with the latest mock data updates:

    ✓ on disconnect, with more than one empty client name (13 ms)
    redirects to /signin when active session is signed out
      ✓ with single service session (60 ms)
      ✓ with multiple service sessions (13 ms)

Test Suites: 1 passed, 1 total
Tests:       25 passed, 25 total
Snapshots:   0 total
Time:        3.409 s
Ran all test suites matching /src\/components\/Settings\/ConnectedServices\/index.test.tsx/i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devices sharing same name are displayed as a single device on connected services

2 participants