fix(fxa-settings): Fix gql loading issues and set password not keeping state

[vbudhram]

Because

• You might see a flash of default state before the account loads in settings
• We didn't update local cache after setting a password

This pull request

• Adds a loading indicator to wait for account state to get loaded before showing setting
• Updates account local storage state after setting password

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-13107
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13109

Checklist

• My commit is GPG signed.
• If applicable, I have modified or added tests which pass locally.
• I have added necessary documentation (if appropriate).
• I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Its kinda hard to reproduce settings refresh issue locally (I wasn't actually able too), but this seems to be reasonable to me what might be going on.

[Copilot]

Pull request overview

This PR fixes two issues in the FXA settings application: a flash of default state before account loads, and the hasPassword field not being updated in local cache after setting a password.

Changes:

• Modified useAccountData hook to use local React state for loading/error instead of persisting to global AccountState context, preventing the flash of default state on page reload
• Updated createPassword and createPasswordWithJwt methods to set hasPassword: true in the account state after creating a password
• Refactored useAccountData to use refs for authClient to prevent unnecessary re-renders and dependency issues

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/fxa-settings/src/models/Account.ts	Added hasPassword: true to state updates in createPassword and createPasswordWithJwt methods
packages/fxa-settings/src/lib/hooks/useAccountData.ts	Refactored to use local state for loading/error, added authClient ref, updated dependency arrays, and removed trailing whitespace

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The destructuring here only removes setAccountData from accountState, but accountState also contains other action functions like updateField, setLoading, setFieldLoading, setError, and clearAccount from the AccountStateActions interface. These action functions will be included in stateData and then spread into the returned data object (line 306), even though the return type AccountState doesn't include them.

Consider destructuring all action functions to keep only the state data, similar to how the old code explicitly removed setLoading and setError. For example:

const {
  setAccountData,
  updateField,
  setLoading,
  setFieldLoading,
  setError,
  clearAccount,
  ...stateData
} = accountState;

This would improve type safety and make the code more explicit about what's being included in the returned data.

Suggested change

	setAccountData,
	setAccountData,
	updateField,
	setLoading,
	setFieldLoading,
	setError,
	clearAccount,

[nshirley]

I was able to test locally and it appears to be working - no delay to show the password field when adding one after unlinking a 3rd party auth account