Conversation
bcolsson
requested changes
Feb 25, 2026
bcolsson
approved these changes
Feb 25, 2026
Because: - Raw DOMExceptions from createCredential() / getCredential() must be translated into semantic, UI-safe categories before they reach components - Error handling strategy (Sentry routing, user messaging) differs by both error type and ceremony context (registration vs. authentication) - WebAuthn browser errors are explicitly out of scope for auth-errors and must not use the errno-based registry (see FXA-12910 for server errors) This commit: - Adds categorizeWebAuthnError(error, operation) — maps DOMException names and TypeError to one of three categories (UserAction, DevicePlatform, Unexpected), returns an operation-specific FTL key and logToSentry flag; never throws - Adds handleWebAuthnError(error, operation, captureException) — single call site that categorizes the error and conditionally fires Sentry - Covers all WebAuthn Level 3 error types including DataError and EncodingError (thrown by parseCreationOptionsFromJSON / parseRequestOptionsFromJSON for malformed options) - Adds FTL strings for all 15 error/operation combinations Closes #FXA-12912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12912
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Based on FXA-12911, only latest commit is relevant for this PR. Will rebase once previous PR is finalized and merged.