fix(settings): Improve fetchLegalTerms and fetchConfig error capture#20097
Merged
fix(settings): Improve fetchLegalTerms and fetchConfig error capture#20097
Conversation
dschom
force-pushed
the
worktree-FXA-13133
branch
4 times, most recently
from
7c570a9 to
7ec4e37
Compare
vbudhram
approved these changes
Feb 25, 2026
| entrypoint: 'preferences', | ||
| cancelled: false, | ||
| errorName: 'Error', | ||
| fetchDuration: 1, |
Contributor
There was a problem hiding this comment.
This might introduce some flakiness, maybe assert any fetchDuration number.
…g with timing and cancellation info Adds fetchDuration (ms), cancelled (AbortError detection), and errorName to the Sentry captureException extra context so 'Load failed' errors are easier to triage by cause and duration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dschom
force-pushed
the
worktree-FXA-13133
branch
from
7ec4e37 to
a60f4f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13133 (Partial, see comments below)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Depending on what we find, we may have to follow up.