Skip to content

chore: add Claude Code skills and unignore .claude/skills#20142

Merged
dschom merged 1 commit intomainfrom
chore-add-skills
Mar 5, 2026
Merged

chore: add Claude Code skills and unignore .claude/skills#20142
dschom merged 1 commit intomainfrom
chore-add-skills

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Mar 5, 2026

Because

  • We want to start adding some claude skills

This pull request

  • unignores .claude/skills/ in .gitignore so skills are tracked in version control.
  • security-review: OWASP, secrets, XSS/injection, CORS, crypto, OTP/TOTP, session replay, rate limiting, PII, Docker, CI
  • check-docs: grammar, typos, JSDoc, README, API docs, changelog summary
  • check-smells: design, implementation, test, and dependency smells
  • check-react: component design, hooks, performance, a11y, state management
  • check-githistory: cross-references current changes against git history for regressions
  • explain-code: architecture, annotated walkthrough, gotchas for experienced engineers

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@@ -0,0 +1,151 @@
---
name: check-smells
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, wouldn't have thought about a "smells" skill.

Copy link
Copy Markdown
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it, lets give it a try 👍🏽


---

### 4. Dependency Smells
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding something to the effect of "colliding exports". Confirming that a newly exported member doesn't have a naming collision elsewhere within the the parent directory (e.g. /libs or /packages). This would prevent bugs where someone incorrectly assumes that they've imported the right version of FooType, when the rest of the surrounding code is using a different definition of FooType.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion 👍. I'll update shortly.

Adds six Claude Code slash command skills:
- security-review: OWASP, secrets, XSS/injection, CORS, crypto, OTP/TOTP, session replay, rate limiting, PII, Docker, CI
- check-docs: grammar, typos, JSDoc, README, API docs, changelog summary
- check-smells: design, implementation, test, and dependency smells
- check-react: component design, hooks, performance, a11y, state management
- check-githistory: cross-references current changes against git history for regressions
- explain-code: architecture, annotated walkthrough, gotchas for experienced engineers

Also unignores .claude/skills/ in .gitignore so skills are tracked in version control.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dschom dschom force-pushed the chore-add-skills branch from d0ebef8 to 72c765f Compare March 5, 2026 19:16
@dschom dschom marked this pull request as ready for review March 5, 2026 19:37
@dschom dschom requested a review from a team as a code owner March 5, 2026 19:37
@dschom dschom merged commit 6a88348 into main Mar 5, 2026
21 checks passed
@dschom dschom deleted the chore-add-skills branch March 5, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants