Conversation
8e45cd4 to
71caeba
Compare
6fc8d7a to
8fdab4f
Compare
| RUN _scripts/l10n/clone.sh | ||
| RUN yarn install --immutable; | ||
| RUN yarn install --immutable \ | ||
| && rm -rf .venv \ |
There was a problem hiding this comment.
Once this PR is merged, L29-31 can be removed.
| python3 --version | ||
| rm -rf .venv | ||
| python3 -m venv .venv --without-pip | ||
| python3 -m venv .venv |
There was a problem hiding this comment.
Once this PR is merged, ensure-glean-venv and all its usages can be removed.
ddb2a3d to
fef4669
Compare
| <GleanPageView | ||
| metricsEnabled={session?.user?.metricsEnabled ?? true} | ||
| pageMetrics={{ pageName: 'management', entrypoint }} | ||
| /> |
There was a problem hiding this comment.
There are no changes below this, I'm not sure why GitHub is saying there were. 😒
| if ( | ||
| reason === 'eligible' && | ||
| !cancelContent.cancelAtPeriodEnd && | ||
| cancelContent.active |
There was a problem hiding this comment.
It would be considered a 'view' if the customer saw the churn content messaging, and would not be a 'view' if they have refreshed the page after having either successfully redeemed a coupon or canceled their subscription.
| staySubscribedContent.active | ||
| ) { | ||
| glean.recordRetentionFlowView(retentionFlowBase); | ||
| } |
There was a problem hiding this comment.
It would be considered a 'view' if the customer saw the churn content messaging, and would not be a 'view' if they have refreshed the page after having either successfully redeemed a coupon or decided to remain canceled.
| useEffect(() => { | ||
| if (pageContent && !cancelAtPeriodEnd) { | ||
| glean.recordInterstitialOfferView(interstitialOfferBase); | ||
| } |
There was a problem hiding this comment.
It would be considered a 'view' if the customer saw the offer content.
| // Glean.setDebugViewTag('payments-frontend'); | ||
| // Glean.setLogPings(true); |
| action: 'upgrade', | ||
| }); | ||
| } | ||
| }, []); // eslint-disable-line |
There was a problem hiding this comment.
Can we state a specific rule here rather than a full disable?
There was a problem hiding this comment.
I believe the comment can actually be removed.
| ) { | ||
| glean.recordRetentionFlowView(retentionFlowBase); | ||
| } | ||
| }, []); // eslint-disable-line |
| ) { | ||
| glean.recordRetentionFlowView(retentionFlowBase); | ||
| } | ||
| }, []); // eslint-disable-line |
| // TODO: This is a workaround to match existing legacy behavior. | ||
| // Fix as part of redesign |
There was a problem hiding this comment.
Can we cite a specific ticket here?
…vention This pull request - Implements the following: - Page_view for Subscription Management - Retention_flow for Cancel and Stay (and Error) - Interstitial_offer for Offer (and Error) Closes PAY-3471
This pull request
Issue that this pull request solves
Closes: PAY-3471
Checklist
Put an
xin the boxes that applyScreenshot
Page View - Subscription Management
Retention Flow
Churn Cancel Flow - cancel subscription
View

Engage

Submit

Result

Churn Cancel Flow - redeem coupon
View

Engage

Submit

Result

Churn Stay Flow
View

Engage

Submit

Result

Interstitial Offer
View

Cancel subscription
Engage

Submit

Result

Upgrade
Engage - note: this action has been updated to 'offer' to distinguish from the second engage (action: upgrade) in the Offer lifecycle

View - Upgrade page

Engage

Submit

Result
