Skip to content

fix(workflows): restore git push credentials in workflows that use pe…#20169

Merged
vpomerleau merged 1 commit intomainfrom
fix-workflows-after-zizmor
Mar 10, 2026
Merged

fix(workflows): restore git push credentials in workflows that use pe…#20169
vpomerleau merged 1 commit intomainfrom
fix-workflows-after-zizmor

Conversation

@vpomerleau
Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau commented Mar 10, 2026

Because

  • A prior security hardening commit added persist-credentials: false to all checkouts across three workflows. While appropriate for read-only checkouts, this setting strips the credential helper from the git config, which broke git push in any checkout that a subsequent push step depends on. The affected checkouts were the gh-pages branch checkouts in cleanup-storybooks and deploy-storybooks, and the sole checkout in tag-release.

This pull request

  • Removes persist-credentials: false from the specific checkouts that feed into push steps, while leaving it in place on read-only checkouts (e.g. the main-repo script checkout in cleanup-storybooks and the repo checkout in deploy-storybooks). This restores implicit GITHUB_TOKEN credential persistence for those steps without widening the credential scope of unrelated checkouts in the same job.

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

This is a partial revert of changes in #20120, which was causing failures for some workflows.

…rsist-credentials: false

Because:

* A prior security hardening commit added persist-credentials: false to all checkouts across three workflows. While appropriate for read-only checkouts, this setting strips the credential helper from the git config, which broke git push in any checkout that a
   subsequent push step depends on. The affected checkouts were the gh-pages branch checkouts in cleanup-storybooks and deploy-storybooks, and the sole checkout in tag-release.

This commit:

* Removes persist-credentials: false from the specific checkouts that feed into push steps, while leaving it in place on read-only checkouts (e.g. the main-repo script checkout in cleanup-storybooks and the repo checkout in deploy-storybooks). This
  restores implicit GITHUB_TOKEN credential persistence for those steps without widening the credential scope of unrelated checkouts in the same job.

Closes #
@vpomerleau vpomerleau requested a review from a team as a code owner March 10, 2026 20:29
@MagentaManifold
Copy link
Copy Markdown
Contributor

Lemme rebase my own branch onto this fix and see if it works

Copy link
Copy Markdown
Contributor

@MagentaManifold MagentaManifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the issue with storybook uploading/cleanup 👍 Not too sure about tag release since idk how to try it out, but it can't go any worse

@vpomerleau vpomerleau merged commit 69fc549 into main Mar 10, 2026
21 checks passed
@vpomerleau vpomerleau deleted the fix-workflows-after-zizmor branch March 10, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants