fix(workflows): restore git push credentials in workflows that use pe…#20169
Merged
vpomerleau merged 1 commit intomainfrom Mar 10, 2026
Merged
fix(workflows): restore git push credentials in workflows that use pe…#20169vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
…rsist-credentials: false Because: * A prior security hardening commit added persist-credentials: false to all checkouts across three workflows. While appropriate for read-only checkouts, this setting strips the credential helper from the git config, which broke git push in any checkout that a subsequent push step depends on. The affected checkouts were the gh-pages branch checkouts in cleanup-storybooks and deploy-storybooks, and the sole checkout in tag-release. This commit: * Removes persist-credentials: false from the specific checkouts that feed into push steps, while leaving it in place on read-only checkouts (e.g. the main-repo script checkout in cleanup-storybooks and the repo checkout in deploy-storybooks). This restores implicit GITHUB_TOKEN credential persistence for those steps without widening the credential scope of unrelated checkouts in the same job. Closes #
Contributor
|
Lemme rebase my own branch onto this fix and see if it works |
MagentaManifold
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
This is a partial revert of changes in #20120, which was causing failures for some workflows.