fix(fxa-settings): skip passwordless OTP redirect for cached sessions#20195
Merged
fix(fxa-settings): skip passwordless OTP redirect for cached sessions#20195
Conversation
…signin page, not OTP redirect
d355432 to
df7d139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
/or/signinThis pull request
!sessionTokenguard inSignin/container.tsxto skip the passwordless OTP redirect when a cached session existshasCachedSessioncheck inIndex/container.tsxhandleSuccessNavigation— readscurrentAccount()fresh from localStorage at call time to detect cached sessionscachedAccountvariable in Index container to consolidatecurrentAccount() || lastStoredAccount()forsuggestedEmailmail_helper.js(x-passwordless-signup-otp,x-passwordless-signin-otp)Index/container.test.tsxandSignin/container.test.tsxfor cached session behaviorFixes: #20195
Checklist
Other Information
How to test:
force_passwordless=truehttp://localhost:3030/— should see cached signin page (avatar + email), NOT the OTP code pagehttp://localhost:3030/signin?email=<your-email>— same behavior