test(functional-tests): add passwordless API functional tests#20196
Merged
test(functional-tests): add passwordless API functional tests#20196
Conversation
vbudhram
force-pushed
the
passwordless-api-tests
branch
3 times, most recently
from
8160001 to
632048c
Compare
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { expect, test } from '../../lib/fixtures/standard'; |
Contributor
There was a problem hiding this comment.
question: Should functional tests be testing the API?
Wouldn't unit tests be a better and less resource intensive fit for this kind of testing?
Contributor
Author
There was a problem hiding this comment.
Should functional tests be testing the API?
Normally I would say its better to keep these as unit tests, but also sometimes good to have functional to test the entire flow. This is similar to our "remote" auth server tests except this is configurable to work on local/stage/prod.
They are a bit slower (1 to 2s) but maybe if its just a few to test core flows?
vbudhram
force-pushed
the
passwordless-api-tests
branch
3 times, most recently
from
f83a39e to
2daaeec
Compare
vbudhram
force-pushed
the
passwordless-api-tests
branch
from
2daaeec to
35dd30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13281
Checklist