chore(settings): change "Not Set" to "Not set"#20202
Conversation
Because: * Jeff says Not Set should be Not set This commit: * changes code to match copy
| # $date (String) - a localized date and time string | ||
| security-password-created-date = Created { $date } | ||
| security-not-set = Not Set | ||
| security-not-set = Not set |
There was a problem hiding this comment.
FTL ids are intentionally not bumped to avoid adding work for localizers. I'll update other English variants manually on Pontoon
There was a problem hiding this comment.
I might be missing something 😅 , how are you able to update the non english variants?
There was a problem hiding this comment.
Is this something @bcolsson recommended? r+ otherwise!
There was a problem hiding this comment.
Yep. Minor changes to styling like this don't often affect other locales (which means nothing would change in translations), so this is a good example of when a string ID change isn't necessary.
There was a problem hiding this comment.
Also kudos @MagentaManifold for recognizing that the other en locales (en-CA and en-GB) would need to be updated. I've gone ahead and updated the translations already.
| # $date (String) - a localized date and time string | ||
| security-password-created-date = Created { $date } | ||
| security-not-set = Not Set | ||
| security-not-set = Not set |
There was a problem hiding this comment.
Yep. Minor changes to styling like this don't often affect other locales (which means nothing would change in translations), so this is a good example of when a string ID change isn't necessary.
| # $date (String) - a localized date and time string | ||
| security-password-created-date = Created { $date } | ||
| security-not-set = Not Set | ||
| security-not-set = Not set |
There was a problem hiding this comment.
Also kudos @MagentaManifold for recognizing that the other en locales (en-CA and en-GB) would need to be updated. I've gone ahead and updated the translations already.
LZoog
left a comment
LZoog
left a comment
There was a problem hiding this comment.
👍 I know Vijay already r+'d but since I commented I'll r+ too.
4 participants
Because
This pull request
Issue that this pull request solves
Closes:
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.