Skip to content

task(passkeys): Use AppErrors instead of passkey.errors.ts#20226

Merged
dschom merged 1 commit intomainfrom
FXA-13303
Mar 20, 2026
Merged

task(passkeys): Use AppErrors instead of passkey.errors.ts#20226
dschom merged 1 commit intomainfrom
FXA-13303

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Mar 20, 2026

Because

  • We want to use AppErrors to simplify error handling

This pull request

  • Removes passkey.errors.ts
  • Ports errors over to AppError
  • Updates references
  • Adds some metrics to go along with errors

Issue that this pull request solves

Closes: FXA-13303

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner March 20, 2026 01:08
@dschom dschom requested a review from nshirley March 20, 2026 01:08
Comment thread libs/accounts/errors/src/index.spec.ts
Comment thread libs/accounts/errors/src/app-error.ts Outdated
Copy link
Copy Markdown
Contributor

@nshirley nshirley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc, just two minor things. I can deal with the conflicts 😅

@dschom dschom merged commit 4ce4abe into main Mar 20, 2026
22 checks passed
@dschom dschom deleted the FXA-13303 branch March 20, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants