Conversation
Because: * After an avatar upload, if a user refreshes or just goes back to Settings at a different point in time, we are hitting /v/profile/default to delete the avatar instead of sending the avatar ID, causing a 400 but giving the usual visual feedback that the avatar has been removed This commit: * Fetches v1/avatar alongside v1/profile to get the current avatar ID * Falls back to null instead of 'default' when no avatar ID is available * Adjusts the functional test to account for this closes FXA-13300
vbudhram
reviewed
Mar 23, 2026
| // avatar ID to be lost (the /v1/profile endpoint doesn't return it) | ||
| await page.reload(); | ||
| await expect(settings.settingsHeading).toBeVisible(); | ||
| await expect(settings.avatar.photo).not.toHaveAttribute('src', /avatar/); |
Contributor
There was a problem hiding this comment.
Had to do a double take .not.toHaveAttribute means the user has an avatar 😅
vbudhram
approved these changes
Mar 23, 2026
Contributor
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
Having some issues starting up my stack but i think the functional test covers this and its pretty low risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-13300
If you copy and paste the functional test changes into
mainyou will see it fail.