fix(payments-next): Upgrading subscription set to cancel does not unset cancelled_for_customer_at#20272
Merged
elizabeth-ilina merged 1 commit intomainfrom Mar 31, 2026
Conversation
elizabeth-ilina
force-pushed
the
PAY-3586-upgrading-subscription-set-to-cancel-does-not-unset-cancelled-for-customer-at
branch
2 times, most recently
from
fac343d to
7a7b095
Compare
julianpoy
reviewed
Mar 30, 2026
|
|
||
| const updatedMetadata = { | ||
| ...subscription.metadata, | ||
| cancelled_for_customer_at: '', |
Member
There was a problem hiding this comment.
This should be left as-is -- we're not updating auth anymore
elizabeth-ilina
force-pushed
the
PAY-3586-upgrading-subscription-set-to-cancel-does-not-unset-cancelled-for-customer-at
branch
2 times, most recently
from
07b36b0 to
91e7879
Compare
…et cancelled_for_customer_at Because: * When upgrading a subscription that has previously been set to cancel but has not cancelled yet, the metadata field cancelled_for_customer_at is not unset even though we uncancel the subscription as part of the upgrade process. This commit: * Removes cancelled_for_customer_at on subscription upgrade. Closes #[PAY-3586](https://mozilla-hub.atlassian.net/browse/PAY-3586)
elizabeth-ilina
force-pushed
the
PAY-3586-upgrading-subscription-set-to-cancel-does-not-unset-cancelled-for-customer-at
branch
from
91e7879 to
5add7f5
Compare
julianpoy
approved these changes
Mar 31, 2026
elizabeth-ilina
deleted the
PAY-3586-upgrading-subscription-set-to-cancel-does-not-unset-cancelled-for-customer-at
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes #PAY-3586
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Cancelled:
Then upgraded (no more cancelled_for_customer_at in the metadata):
Other information (Optional)
Any other information that is important to this pull request.