Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression where clients could treat the post-password-change session as unverified (and sign the user out) by ensuring the /mfa/password/change response includes the sessionVerified flag that downstream account storage expects (Closes: FXA-13355).
Changes:
- Add
sessionVerifiedto the/mfa/password/changeroute response, sourced from the newly issued session token’s verification state. - Add/adjust unit tests to assert
sessionVerifiedis present and consistent with the legacyverifiedfield.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/fxa-auth-server/lib/routes/password.ts |
Include sessionVerified in the password change response payload. |
packages/fxa-auth-server/lib/routes/password.spec.ts |
Add a test ensuring sessionVerified is returned (and keep formatting tidy in an existing assertion). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vpomerleau
approved these changes
Apr 7, 2026
vbudhram
approved these changes
Apr 7, 2026
Contributor
vbudhram
left a comment
There was a problem hiding this comment.
Could add a functional test in passwordless to cover the flow
Contributor
Author
|
Latest force push was adding a functional test for this bug! |
Because: - There's a bug where a user can be signed out after changing password This Commit: - Fixes the issue by providing the proper sessionVerified property in the API response for the client to cache Closes: FXA-13355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
sessionVerifiedproperty thatupdateBasicAccountDatalooks for.Issue that this pull request solves
Closes: FXA-13355
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.