Skip to content

fix(tests): pass WAF header to passwordless API calls #20337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbudhram merged 1 commit into from
Apr 8, 2026
Merged

fix(tests): pass WAF header to passwordless API calls #20337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/functional-tests/lib/testAccountTracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,14 @@ export class TestAccountTracker {
const password = this.generatePassword();

// Send passwordless code
await this.target.authClient.passwordlessSendCode(email, {
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
});
await this.target.authClient.passwordlessSendCode(
email,
{
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
},
this.target.ciHeader
);

// Get OTP from email
const code = await this.target.emailClient.getPasswordlessSignupCode(email);
Expand All @@ -276,7 +280,8 @@ export class TestAccountTracker {
{
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
}
},
this.target.ciHeader
);

// Track for cleanup - mark as passwordless so cleanup knows to handle specially
Expand Down Expand Up @@ -457,10 +462,14 @@ export class TestAccountTracker {
): Promise<void> {
try {
// Send passwordless code
await this.target.authClient.passwordlessSendCode(account.email, {
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
});
await this.target.authClient.passwordlessSendCode(
account.email,
{
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
},
this.target.ciHeader
);

// Get OTP from email
const code = await this.target.emailClient.getPasswordlessSigninCode(
Expand All @@ -474,7 +483,8 @@ export class TestAccountTracker {
{
clientId: this.target.relierClientID,
service: SUPPORTED_SERVICE,
}
},
this.target.ciHeader
);

let sessionToken = result.sessionToken;
Expand Down
180 changes: 121 additions & 59 deletions packages/functional-tests/tests/passwordless/passwordlessApi.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,26 @@ async function getPasswordlessSession(
email: string,
isNew: boolean
) {
await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);
const code = isNew
? await target.emailClient.getPasswordlessSignupCode(email)
: await target.emailClient.getPasswordlessSigninCode(email);
return target.authClient.passwordlessConfirmCode(email, code, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
return target.authClient.passwordlessConfirmCode(
email,
code,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);
}

test.describe('severity-2', () => {
Expand All @@ -36,10 +45,14 @@ test.describe('severity-2', () => {
const { email } =
testAccountTracker.generatePasswordlessAccountDetails();

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSignupCode(email);
expect(code).toBeTruthy();
Expand All @@ -51,10 +64,14 @@ test.describe('severity-2', () => {
}) => {
const { email } = await testAccountTracker.signUpPasswordless();

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSigninCode(email);
expect(code).toBeTruthy();
Expand All @@ -67,10 +84,14 @@ test.describe('severity-2', () => {
const credentials = await testAccountTracker.signUp();

try {
await target.authClient.passwordlessSendCode(credentials.email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
credentials.email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);
expect(
true,
'passwordlessSendCode should have been rejected for password account'
Expand All @@ -88,9 +109,13 @@ test.describe('severity-2', () => {
testAccountTracker.generatePasswordlessAccountDetails();

try {
await target.authClient.passwordlessSendCode(email, {
clientId: 'deadbeefdeadbeef',
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: 'deadbeefdeadbeef',
},
target.ciHeader
);
expect(
true,
'passwordlessSendCode should have been rejected for non-allowlisted client'
Expand All @@ -112,10 +137,14 @@ test.describe('severity-2', () => {
(a) => a.email === email
);

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSignupCode(email);
const result = await target.authClient.passwordlessConfirmCode(
Expand All @@ -124,7 +153,8 @@ test.describe('severity-2', () => {
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
}
},
target.ciHeader
);

expect(result.verified).toBe(true);
Expand All @@ -150,10 +180,14 @@ test.describe('severity-2', () => {
);
const password = account?.password || '';

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSigninCode(email);
const result = await target.authClient.passwordlessConfirmCode(
Expand All @@ -162,7 +196,8 @@ test.describe('severity-2', () => {
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
}
},
target.ciHeader
);

expect(result.verified).toBe(true);
Expand All @@ -185,19 +220,28 @@ test.describe('severity-2', () => {
const { email } =
testAccountTracker.generatePasswordlessAccountDetails();

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

// Consume the real code so we can test with a bogus one
await target.emailClient.getPasswordlessSignupCode(email);

try {
await target.authClient.passwordlessConfirmCode(email, '00000000', {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessConfirmCode(
email,
'00000000',
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);
expect(
true,
'passwordlessConfirmCode should have rejected invalid OTP'
Expand Down Expand Up @@ -231,16 +275,21 @@ test.describe('severity-2', () => {
account.sessionToken = sessionToken;
}

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSigninCode(email);
const result = await target.authClient.passwordlessConfirmCode(
email,
code,
{ clientId: target.relierClientID, service: SUPPORTED_SERVICE }
{ clientId: target.relierClientID, service: SUPPORTED_SERVICE },
target.ciHeader
);

expect(result.verified).toBe(false);
Expand Down Expand Up @@ -273,24 +322,33 @@ test.describe('severity-2', () => {
(a) => a.email === email
);

await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

await target.emailClient.getPasswordlessSignupCode(email);

await target.authClient.passwordlessResendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessResendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);

const code = await target.emailClient.getPasswordlessSignupCode(email);

const result = await target.authClient.passwordlessConfirmCode(
email,
code,
{ clientId: target.relierClientID, service: SUPPORTED_SERVICE }
{ clientId: target.relierClientID, service: SUPPORTED_SERVICE },
target.ciHeader
);
expect(result.verified).toBe(true);

Expand Down Expand Up @@ -430,10 +488,14 @@ test.describe('severity-2', () => {

// Passwordless send should be rejected after password creation
try {
await target.authClient.passwordlessSendCode(email, {
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
});
await target.authClient.passwordlessSendCode(
email,
{
clientId: target.relierClientID,
service: SUPPORTED_SERVICE,
},
target.ciHeader
);
expect(
true,
'passwordlessSendCode should have been rejected for account with password'
Expand Down
Loading
Loading