Skip to content

fix(storybook): remove build script for payment-server's storybook#20348

Merged
MagentaManifold merged 1 commit intomainfrom
dont-build-sp2-storybook
Apr 9, 2026
Merged

fix(storybook): remove build script for payment-server's storybook#20348
MagentaManifold merged 1 commit intomainfrom
dont-build-sp2-storybook

Conversation

@MagentaManifold
Copy link
Copy Markdown
Contributor

Because

  • payment-server is no longer used and its storybook is no longer useful

This pull request

  • removes the build script for payment-server's storybook so that it no longer gets built

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

* payment-server is no longer used and its storybook is no longer useful

This commit:

* removes the build script for payment-server's storybook so that it no longer gets built
Copilot AI review requested due to automatic review settings April 9, 2026 21:19
@MagentaManifold MagentaManifold requested a review from a team as a code owner April 9, 2026 21:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables building the (legacy) fxa-payments-server Storybook by removing its build-storybook script, aligning with the goal of no longer generating Storybook artifacts for an unused package.

Changes:

  • Removed the build-storybook npm script from packages/fxa-payments-server/package.json so Nx/CI no longer has a build-storybook target to run for this package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

@MagentaManifold MagentaManifold merged commit e14bd92 into main Apr 9, 2026
24 checks passed
@MagentaManifold MagentaManifold deleted the dont-build-sp2-storybook branch April 9, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants