fix(storybook): remove build script for payment-server's storybook#20348
Merged
MagentaManifold merged 1 commit intomainfrom Apr 9, 2026
Merged
fix(storybook): remove build script for payment-server's storybook#20348MagentaManifold merged 1 commit intomainfrom
MagentaManifold merged 1 commit intomainfrom
Conversation
Because: * payment-server is no longer used and its storybook is no longer useful This commit: * removes the build script for payment-server's storybook so that it no longer gets built
There was a problem hiding this comment.
Pull request overview
This PR disables building the (legacy) fxa-payments-server Storybook by removing its build-storybook script, aligning with the goal of no longer generating Storybook artifacts for an unused package.
Changes:
- Removed the
build-storybooknpm script frompackages/fxa-payments-server/package.jsonso Nx/CI no longer has a build-storybook target to run for this package.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.