Skip to content

fix(admin): fix email bounce type display#20378

Merged
MagentaManifold merged 1 commit intomainfrom
FXA-13417
Apr 15, 2026
Merged

fix(admin): fix email bounce type display#20378
MagentaManifold merged 1 commit intomainfrom
FXA-13417

Conversation

@MagentaManifold
Copy link
Copy Markdown
Contributor

Because

  • email bounce types are shown as enum integers instead of strings

This pull request

  • make the backend endpoint return transformed strings directly.

Issue that this pull request solves

Closes: FXA-13417

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts: you'll need to add an email bounce to db manually because there's no way to simulate it yet.

Screenshots (Optional)

image

Other information (Optional)

Any other information that is important to this pull request.

Because:

* email bounce types are shown as enum integers instead of strings

This commit:

* make the backend endpoint return transformed strings dirrectly.

Closes FXA-13417
@MagentaManifold MagentaManifold requested a review from a team as a code owner April 15, 2026 16:15
Copilot AI review requested due to automatic review settings April 15, 2026 16:15

// ─── Field resolver helpers (public so integration tests can call them) ───

@Features(AdminPanelFeature.AccountSearch)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be present for other account search methods, so I assume this one should have it as well. Same for the other one below.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the admin account search payload so email bounce types/subtypes are returned as human-readable strings (instead of numeric enum values), matching what the admin panel expects to display.

Changes:

  • Transform bounceType and bounceSubType from numeric DB values to string enum names in emailBounces().
  • Add @Features(AdminPanelFeature.AccountSearch) metadata to emailBounces() and linkedAccounts() helper methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MagentaManifold MagentaManifold merged commit 4ed7c70 into main Apr 15, 2026
24 checks passed
@MagentaManifold MagentaManifold deleted the FXA-13417 branch April 15, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants