chore(all): replace esbuild-register with ts-node/register in pm2, sc…#20390
Draft
chore(all): replace esbuild-register with ts-node/register in pm2, sc…#20390
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| await execAsync( | ||
| `node -r esbuild-register scripts/dump-users --emails ${account1Mock.email},${account2Mock.email} > ${USER_DUMP_PATH}`, | ||
| `node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/dump-users --emails ${account1Mock.email},${account2Mock.email} > ${USER_DUMP_PATH}`, |
| it('succeeds with valid input file and method, writing files to disk', async () => { | ||
| await execAsync( | ||
| `node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail --write ${OUTPUT_DIRECTORY}`, | ||
| `node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail --write ${OUTPUT_DIRECTORY}`, |
| it('succeeds with valid input file and method, writing emails to stdout', async () => { | ||
| const output = await execAsync( | ||
| `node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail`, | ||
| `node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendPasswordChangedEmail`, |
| it('succeeds with valid input file and method, sends', async () => { | ||
| await execAsync( | ||
| `node -r esbuild-register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendVerifyEmail --send`, | ||
| `node -r ts-node/register/transpile-only -r tsconfig-paths/register scripts/bulk-mailer --input ${USER_DUMP_PATH} --method sendVerifyEmail --send`, |
dschom
force-pushed
the
worktree-switch-to-ts-node
branch
3 times, most recently
from
98473ba to
4abad51
Compare
…ripts, and mocha commands chore(all): Use tsc instead of esbuild Because: - We want to test & develop with what we deploy This Commit: - Removes esbuild - Uses tsc & ts-node instead - Fixes several nx config issues that were messing up caching - Fixes esm hacks for vendored modules - Creates dedicated build-ts target for typescript compilation, which makes nx task dependencies easier to configure. - Updates startup commands to use ts-node
dschom
force-pushed
the
worktree-switch-to-ts-node
branch
from
4abad51 to
a6d1a55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ripts, and mocha commands
chore(all): Use tsc instead of esbuild
Because:
This Commit:
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.