Skip to content

chore(glean): upgrade @mozilla/glean to 5.0.8 and glean_parser to v19#20392

Open
vbudhram wants to merge 1 commit intomainfrom
fxa-13435
Open

chore(glean): upgrade @mozilla/glean to 5.0.8 and glean_parser to v19#20392
vbudhram wants to merge 1 commit intomainfrom
fxa-13435

Conversation

@vbudhram
Copy link
Copy Markdown
Contributor

Because

  • A bug in glean_parser <v19 / glean.js <v5.0.8 caused server-side Glean events for accounts_backend and subscription_platform_backend to have wildly incorrect timestamps (DENG-10432)
  • This was flagged by the Data Engineering team as a priority fix

This pull request

  • Bumps @mozilla/glean from 5.0.4 to 5.0.8 in root package.json
  • Updates yarn.lock with the new resolved version
  • Regenerates all Glean code with glean_parser v19.0.0 (up from v14.5.2):
    • fxa-auth-server server events (TypeScript)
    • fxa-content-server client + server events (JavaScript)
    • fxa-shared web metrics (TypeScript)
  • Payments __generated__ files are gitignored and rebuilt by CI

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-13435

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

Other information

Versions:

  • @mozilla/glean: 5.0.4 → 5.0.8
  • glean_parser: 14.5.2 → 19.0.0

Most of the 56 changed files are auto-generated Glean code with version string bumps

@vbudhram vbudhram self-assigned this Apr 16, 2026
@vbudhram vbudhram requested a review from a team as a code owner April 16, 2026 18:54
Copilot AI review requested due to automatic review settings April 16, 2026 18:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s Glean JS SDK and regenerates Glean metric/event code to address known server-side timestamp issues in generated server events.

Changes:

  • Bump @mozilla/glean dependency to ^5.0.8 and update yarn.lock.
  • Regenerate Glean metrics/event code using glean_parser v19.0.0 across auth-server, content-server, and shared web metrics.
  • Update generated ping definitions (e.g., followsCollectionEnabled, uploaderCapabilities) and expand some event extras/metrics definitions (e.g., OTP-related events, reason/scopes extras).

Reviewed changes

Copilot reviewed 58 out of 59 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bumps @mozilla/glean to ^5.0.8.
yarn.lock Updates lockfile resolution/checksum for @mozilla/glean@5.0.8.
packages/fxa-auth-server/lib/metrics/glean/server_events.ts Regenerated server event logger (parser v19); timestamp handling and updated telemetry build string.
packages/fxa-content-server/server/lib/glean/server_events.js Regenerated server event logger (parser v19); timestamp handling, updated telemetry build string, and updated event extras.
packages/fxa-shared/metrics/glean/web/account.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/accountBanner.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/accountPref.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cachedLogin.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cad.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadApproveDevice.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadFirefox.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadMobilePair.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadMobilePairUseApp.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadRedirectDesktop.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/cadRedirectMobile.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/deleteAccount.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/email.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/entrypoint.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/error.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/event.ts Regenerated web metric definitions header (parser v19) and import ordering.
packages/fxa-shared/metrics/glean/web/login.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/passwordReset.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/pings.ts Regenerated ping definition; adds followsCollectionEnabled and uploaderCapabilities.
packages/fxa-shared/metrics/glean/web/promoQrMobile.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/reg.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/relyingParty.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/session.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/thirdPartyAuth.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/thirdPartyAuthSetPassword.ts Regenerated web metric definitions header (parser v19).
packages/fxa-shared/metrics/glean/web/utm.ts Regenerated web metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/account.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/accountBanner.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/accountPref.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cachedLogin.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cad.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadApproveDevice.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadFirefox.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadMobilePair.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadMobilePairUseApp.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadRedirectDesktop.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/cadRedirectMobile.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/deleteAccount.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/email.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/entrypoint.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/error.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/event.js Regenerated content-server client metric definitions header (parser v19) and import ordering.
packages/fxa-content-server/app/scripts/lib/glean/login.js Regenerated client login events; adds new OTP-related event metric definitions.
packages/fxa-content-server/app/scripts/lib/glean/passwordReset.js Regenerated client password reset events; updates allowed extra keys for some events.
packages/fxa-content-server/app/scripts/lib/glean/pings.js Regenerated ping definition; adds followsCollectionEnabled and uploaderCapabilities.
packages/fxa-content-server/app/scripts/lib/glean/promoQrMobile.js Adds new generated client metric file for promo_qr_mobile.view.
packages/fxa-content-server/app/scripts/lib/glean/reg.js Regenerated client registration events; adds new OTP-related event metric definitions.
packages/fxa-content-server/app/scripts/lib/glean/relyingParty.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/session.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/thirdPartyAuth.js Regenerated third-party auth client events; schema output changed (notably deeplink events).
packages/fxa-content-server/app/scripts/lib/glean/thirdPartyAuthSetPassword.js Regenerated content-server client metric definitions header (parser v19).
packages/fxa-content-server/app/scripts/lib/glean/utm.js Regenerated content-server client metric definitions header (parser v19).
Comments suppressed due to low confidence (1)

packages/fxa-content-server/app/scripts/lib/glean/thirdPartyAuth.js:23

  • This regenerated metrics file no longer exports appleDeeplink / googleDeeplink, but those metrics are still referenced elsewhere (e.g. packages/fxa-content-server/app/scripts/lib/glean/index.ts calls thirdPartyAuth.googleDeeplink.record() / appleDeeplink.record(), and views/tests call GleanMetrics.thirdPartyAuth.*Deeplink()). As-is, this will break the content-server build at import/compile time. Either restore the third_party_auth.*_deeplink event definitions in the Glean schema and regenerate, or remove/update the corresponding call sites and event mappings/tests to match the updated schema.
// AUTOGENERATED BY glean_parser v19.0.0. DO NOT EDIT. DO NOT COMMIT.

import EventMetricType from '@mozilla/glean/private/metrics/event';

/**
 * User click "Continue with Apple" from the login page
 *
 * Generated from `third_party_auth.apple_login_start`.
 */
export const appleLoginStart = new EventMetricType(
  {
    category: 'third_party_auth',
    name: 'apple_login_start',
    sendInPings: ['events'],
    lifetime: 'ping',
    disabled: false,
  },
  []
);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks Vijay!

Because:
- glean_parser <v19 / glean.js <v5.0.8 caused server-side Glean events
  to have wildly incorrect timestamps (DENG-10432)

This commit:
- Bumps @mozilla/glean from 5.0.4 to 5.0.8
- Updates glean_parser from ~=14.5 to ~=19.0 in CI and mono Dockerfiles
- Recreates venv with glean_parser 19 in CI provision step and
  persists .venv to the workspace to avoid pip uninstall bug that
  hits when cached Docker images still have 14.5.2
- Regenerates all Glean code with glean_parser v19.0.0
- Removes orphaned generated files (standard.js, sync.js, webauthn.js)
  whose metrics were previously removed from YAML definitions
- Fixes timestamp bug for accounts_backend and
  subscription_platform_backend server events

Fixes FXA-13435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants